From: Florian Müllner Date: Fri, 17 Jan 2014 15:05:09 +0000 (-0500) Subject: altTab: Always filter out items with no windows X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2887 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=9d8f8277aa5f5de8e68ef958b5198b2d58f34717;p=gnome-shell.git altTab: Always filter out items with no windows When restricting the switcher popup to the current workspace, we filter out running apps with an empty window list (namely: no open windows on the current workspace). However we may end up with an empty window list even when not restricting items to the current workspace when all windows of a running app are associated with a different application via the transient_for hint. To fix this, just filter out items with an empty window list unconditionally. https://bugzilla.gnome.org/show_bug.cgi?id=722434 --- diff --git a/js/ui/altTab.js b/js/ui/altTab.js index 525adc260..adfb02d92 100644 --- a/js/ui/altTab.js +++ b/js/ui/altTab.js @@ -460,9 +460,10 @@ const AppSwitcher = new Lang.Class({ appIcon.cachedWindows = allWindows.filter(function(w) { return windowTracker.get_window_app (w) == appIcon.app; }); - if (workspace == null || appIcon.cachedWindows.length > 0) { + if (appIcon.cachedWindows.length > 0) this._addIcon(appIcon); - } + else if (workspace == null) + throw new Error('%s appears to be running, but doesn\'t have any windows'.format(appIcon.app.get_name())); } this._curApp = -1;